feat: allow custom args in kubectl apply for kubernetes deployments
#6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Ruck <[email protected]>
stefreak
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
For server-side apply in particular, I'd like native Garden support and/or to enable it by default if it's supported by all Kubernetes versions we support.
But it might still be useful to also allow additional parameters to kubectl as another escape hatch in the future.
vvagaytsev
changed the title
vvagaytsev
changed the title
kubectl apply for kubernetes deployments
|
@stefreak I think I missed here something 🫣 adding tests and the applyArgs to the apply function itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See the Discord thread for details: https://discord.com/channels/817392104711651328/1077431043482714282
Which issue(s) this PR fixes:
Fixes #3839
Special notes for your reviewer: