improvement(api): send action type to cloud #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
2 times, most recently
from
1178087 to
4b5d7e2
Compare
eysi09
commented
Nov 21, 2023
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
6 times, most recently
from
4d339c8 to
01d0522
Compare
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
from
01d0522 to
ce93d19
Compare
eysi09
commented
Oct 10, 2024
| @@ -115,7 +115,7 @@ describe("kubernetes-type handlers", () => { | |||
| } | |||
|
|
|||
| async function deployInNamespace({ nsName, deployName }: { nsName: string; deployName: string }) { | |||
| garden.setModuleConfigs([withNamespace(nsModuleConfig, nsName)]) | |||
| garden.mergeModuleConfigs([withNamespace(nsModuleConfig, nsName)]) | |||
There was a problem hiding this comment.
In the previous version these tests were actually not working right because when setting the module config here we replaced the actual module configs from the test projects.
With this change we now merge the module config we're setting dynamically with the existing configs so that nothing gets overwritten.
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
from
ce93d19 to
67e8830
Compare
vvagaytsev
approved these changes
Oct 10, 2024
vvagaytsev
requested changes
Oct 10, 2024
Before this improvement we weren't sending the action type to Cloud due to some legacy issues which have since been resolved. The action type is used in Cloud in e.g. the graph UI and on command results. Note that Cloud has already been updated to handle the action type and those changes rolled out to all users, so this is only required Core side work.
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
from
67e8830 to
234bad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sends the action type to cloud so that it can e.g. be displayed in the graph UI and in command results in general.
We weren't doing that previously because a bit of a legacy baggage but that has been resolved.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Garden Cloud itself was updated awhile ago to handle this data so this only required Core fixes.