Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: highlight is not a function #5442

Open
stefreak opened this issue Nov 20, 2023 · 2 comments
Open

Crash: highlight is not a function #5442

stefreak opened this issue Nov 20, 2023 · 2 comments
Labels
bug crash regression A return to a previous and less advanced or worse state

Comments

@stefreak
Copy link
Member

stefreak commented Nov 20, 2023

Crash report

Error message

Unable to resolve status for Deploy foo. It is likely missing or outdated. This can come up if the deployment has runtime dependencies that are not resolvable, i.e. not deployed or invalid.

and

Encountered an unexpected Garden error. This is likely a bug 🍂

You can help by reporting this on GitHub: https://github.com/garden-io/garden/issues/new?labels=bug,crash&template=CRASH.md&title=Crash%3A%20highlight%20is%20not%20a%20function

Please attach the following information to the bug report after making sure that the error message does not contain sensitive information:

TypeError: highlight is not a function
    at highlightYaml (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:214964:12)
    at renderData (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215093:16)
    at file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215002:40
    at Array.map (<anonymous>)
    at combineRenders (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215002:22)
    at formatForTerminal (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215133:12)
    at TerminalWriter.write (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215499:21)
    at RootLogger.log (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:309828:24)
    at CoreLog.log (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215285:19)
    at CoreLog.info (file:///Users/steffen/Library/Application%20Support/io.garden.garden/1700246687-AJiCnyg.r/rollup/garden.mjs:215336:21)

See .garden/error.log for detailed error message

What did you do?

ran garden get status with this config:

# garden.yml
apiVersion: garden.io/v1
kind: Project
name: foo
environments:
  - name: local

---
kind: Build
type: exec
name: foo
spec:
  command: [echo, "hello world"]


---
kind: Deploy
type: exec
name: foo
spec:
  deployCommand: [echo, "${actions.build.foo.outputs.log}"]

---

kind: Test
type: exec
name: foo
dependencies:
 - deploy.foo
spec:
  command: [echo, "Success"]

Your environment

  • OS: macOS
  • Garden version: 0.13.20

Frequency

Reproducable

Workaround

Downgrade to 0.13.19 until we released a fixed version

Additional context

@stefreak
Copy link
Member Author

Only seems to happen with release binaries, so this seems to be an issue caused by rollup bundling.

@vvagaytsev vvagaytsev added the regression A return to a previous and less advanced or worse state label Nov 24, 2023
@vvagaytsev
Copy link
Collaborator

We have a PR with the rollup version bump (#5518), but it does not fix the issue.

vvagaytsev added a commit that referenced this issue Dec 14, 2023
This is a quickfix for #5442 to avoid Garden crashes on yaml highlighting.
The proper fix still needs to be implemented.
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2023
This is a quickfix for #5442 to avoid Garden crashes on yaml highlighting.
The proper fix still needs to be implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash regression A return to a previous and less advanced or worse state
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants