0.12 backport: improvement: using new release endpoint for self-update #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improvement: using a new release endpoint for self-update * test: fixed self-update tests to mock the release endpoint * docs: architecture flag in self-update command * improvement: better error handling when retrieving releases * test: releases endpoint failure and clarifying comments on desired version --------- Co-authored-by: Anna Mager <[email protected]>
|
@mkhq thanks for back-porting this! The docs need to be re-generated. The rest test failures and known and expected. |
vvagaytsev
requested changes
Oct 16, 2023
core/src/constants.ts
Outdated
| @@ -47,8 +47,7 @@ export const SUPPORTED_ARCHITECTURES: SupportedArchitecture[] = ["x64", "arm64"] | |||
| export const SEGMENT_DEV_API_KEY = "D3DUZ3lBSDO3krnuIO7eYDdtlDAjooKW" // ggignore | |||
| export const SEGMENT_PROD_API_KEY = "b6ovUD9A0YjQqT3ZWetWUbuZ9OmGxKMa" // ggignore | |||
|
|
|||
| export const DOCS_BASE_URL = "https://docs.garden.io/v/acorn-0.12" | |||
| export const VERSION_CHECK_URL = "https://get.garden.io/version" | |||
| export const DOCS_BASE_URL = "https://docs.garden.io" | |||
There was a problem hiding this comment.
This must be DOCS_BASE_URL = "https://docs.garden.io/v/acorn-0.12" in the 0.12 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a 0.12 backport of #5229. Tests and code are ported over. ARM support was excluded from the backport since its only available from 0.13.12.
Which issue(s) this PR fixes:
Fixes #4893
Special notes for your reviewer: