Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: allow for concurrent JIB maven builds #4635

Closed
tedchang77 opened this issue Jun 14, 2023 · 2 comments · Fixed by #4709
Closed

[FEATURE]: allow for concurrent JIB maven builds #4635

tedchang77 opened this issue Jun 14, 2023 · 2 comments · Fixed by #4709

Comments

@tedchang77
Copy link

Feature Request

add configuration to allow for concurrent jib maven builds

Background / Motivation

currently jib maven builds are done in serial increasing the time it takes to build multiple images.

What should the user be able to do?

run garden build on the stack graph and have builds done in parallel.

Why do they want to do this? What problem does it solve?

speed up the time it takes to build images.

Suggested Implementation(s)

allow locking behaviour to be configurable:

return buildLock.acquire("mvn", async () => {

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden painful

@vvagaytsev vvagaytsev moved this to Candidate in Core Weekly Jun 19, 2023
@vvagaytsev vvagaytsev self-assigned this Jun 19, 2023
@vvagaytsev vvagaytsev moved this from Candidate to Todo in Core Weekly Jun 19, 2023
@vvagaytsev vvagaytsev moved this from Todo to In Progress in Core Weekly Jun 20, 2023
@vvagaytsev
Copy link
Collaborator

vvagaytsev commented Jun 20, 2023

Possible solutions:

@vvagaytsev
Copy link
Collaborator

vvagaytsev commented Jun 26, 2023

A config option to allow concurrent maven builds was implemented in #4709. It's marked as an experimental feature and can be tried with Maven builds. The Maven Daemon has some issues with concurrent executions.

Garden has built-in concurrency control to avoid the execution of too many builds simultaneously:

So, using regular maven in concurrent mode should not be an issue. It won't produce too many processes. Garden uses Maven 3.8.8, the issue with concurrent access to the local repo was solved in 3.8.2, see https://issues.apache.org/jira/browse/MNG-2802

@vvagaytsev vvagaytsev moved this from In Progress to Done in Core Weekly Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants