Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy util service if using kaniko #1963

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

ThisGuyCodes
Copy link
Contributor

@ThisGuyCodes ThisGuyCodes commented Jul 28, 2020

The util service was only being deployed if we were using an external registry. However kaniko works fine with an in-cluster registry, and kaniko requires the util service.

Fixes #1962


This change is Reviewable

The util service was only being deployed if we were using an external registry. However kaniko works fine with an in-cluster registry, and kaniko requires the util service.

Fixes garden-io#1962
@ThisGuyCodes
Copy link
Contributor Author

@eysi09, @10ko

It said to add reviewers + label the PR, but the "what kind of PR is this" section referenced wasn't there, maybe I'm a bit blind.

I'd love to have a test for this too, any guidance?

@ThisGuyCodes
Copy link
Contributor Author

ok that commit was a lint change and now minikube 1.15 is failing. Any guidance?

@ThisGuyCodes
Copy link
Contributor Author

before retry:

  • 1.17 passing
  • 1.15 failing

after retry (no changes outside the commit timestamp):

  • 1.17 failing
  • 1.15 passing

I'm at a loss.

@edvald edvald merged commit 42203bb into garden-io:master Jul 29, 2020
@edvald
Copy link
Collaborator

edvald commented Jul 29, 2020

Thanks @ThisGuyCodes! Looks good. You just ran into some flaky tests there, no issues with the change that I could see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container builds with Kaniko fail (no "garden-util-daemon")
2 participants