Skip to content

Commit

Permalink
chore: make timeout required in runBaseParams
Browse files Browse the repository at this point in the history
Non-optional value  is always set from outside.
  • Loading branch information
vvagaytsev committed May 11, 2023
1 parent e0f8515 commit f7c1cbf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions core/src/plugin/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ export const moduleActionParamsSchema = () =>
export const runBaseParams = () => ({
interactive: joi.boolean().description("Whether to run interactively (i.e. attach to the terminal)."),
silent: joi.boolean().description("Set to false if the output should not be logged to the console."),
// TODO-0.13.0: revisit this, the timeout might not need to be optional
timeout: joi.number().optional().description("If set, how long to run the command before timing out."),
timeout: joi.number().required().description("If set, how long to run the command before timing out."),
})

// TODO-0.13.0: update this schema in 0.13.0
Expand Down

0 comments on commit f7c1cbf

Please sign in to comment.