Merge pull request #1355 from garden-io/fix-dashboard-logs-page

fix(dashboard): fix hooks render order on logs page
garden-io · Nov 20, 2019 · d94b0a8 · d94b0a8
2 parents 483302b + fb80d34
commit d94b0a8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/dashboard/package.json b/dashboard/package.json
@@ -54,7 +54,7 @@
     "build": "react-scripts build && ./bin/copy-to-static",
     "dev": "EXTEND_ESLINT=true npm run start",
     "fix-format": "prettier --write \"{src,test}/**/*.{ts,tsx}\"",
-    "lint": "tslint -p .",
+    "lint": "eslint \"{src,test}/**/*.{ts,tsx}\"",
     "test-watch": "react-scripts test",
     "test": "CI=true react-scripts test",
     "eject": "react-scripts eject"

diff --git a/dashboard/src/containers/logs.tsx b/dashboard/src/containers/logs.tsx
@@ -36,6 +36,13 @@ export default () => {
     }
   }, [dispatch, requestStates.logs, serviceNames])
 
+  const handleRefresh = useCallback(
+    (names: string[]) => {
+      loadLogs(dispatch, names)
+    },
+    [dispatch]
+  )
+
   if (!(requestStates.config.initLoadComplete && requestStates.logs.initLoadComplete)) {
     return <Spinner />
   }
@@ -44,12 +51,5 @@ export default () => {
     return <PageError error={requestStates.config.error || requestStates.logs.error} />
   }
 
-  const handleRefresh = useCallback(
-    (names: string[]) => {
-      loadLogs(dispatch, names)
-    },
-    [dispatch]
-  )
-
   return <Logs onRefresh={handleRefresh} logs={logs} />
 }