Skip to content

Commit

Permalink
chore: fix entrypoint in azure dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
@edvald
edvald committed Aug 12, 2021
1 parent 08e6d4a commit d241d14
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions support/azure.Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
ARG TAG=latest
FROM gardendev/garden:${TAG}


# Build dependencies
RUN apk add --virtual=build gcc libffi-dev musl-dev openssl-dev make readline linux-pam \
# Runtime dependency
Expand All @@ -20,6 +19,3 @@ RUN wget -O kubelogin-linux-amd64.zip https://github.com/Azure/kubelogin/release

# Required by Azure DevOps to tell the system where node is installed
LABEL "com.azure.dev.pipelines.agent.handler.node.path"="/usr/local/bin/node"

ENTRYPOINT []

3 comments on commit d241d14

@ITHedgeHog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edvald Did this cause an issue else where? As it was required for Azure DevOps to use the image.

@edvald
Copy link
Collaborator Author

@edvald edvald commented on d241d14 Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that @ITHedgeHog! It did cause an issue, yes. Other tests failed because the entrypoint was assumed, and I sorta figured this was a breaking change for the image. But then, if you use a specific version of the image, I suppose you could just remove the assumed entrypoint when updating.

I take it there's no way to work around this in Azure DevOps?

@ITHedgeHog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not that I've ever seen @edvald - is it just worth creating an extra docker file and creating a container called garden-azure-devops which has the endpoint set to empty? Let me know if you think that is a good idea, I'll raise another issue and have a look at the tests you run on the containers to see what would need to be written for this.

It's not blocking for me as I've gone back to our custom image internally.

Please sign in to comment.