Skip to content

Commit

Permalink
improvement(core): log stderr from exec as info
Browse files Browse the repository at this point in the history
Before this change, we logged stderr stream from exec provider
init scripts as errors but now we log it at the info level.

The reason is that some tools, e.g. gcloud, write to stderr even if it's
not an actual error.

In the case of an actual error the script exits with a non-zero
code and that's handled specifically.

So this is really just a cosmetic change to how exec provider logs are
rendered.
  • Loading branch information
eysi09 committed Oct 10, 2023
1 parent 3ac6e65 commit be63891
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/util/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ export async function runScript({
log.error(line.toString())
})
errorStream.on("data", (line: Buffer) => {
log.error(line.toString())
log.info(line.toString())
})
// Workaround for https://github.com/vercel/pkg/issues/897
env.PKG_EXECPATH = ""
Expand Down

0 comments on commit be63891

Please sign in to comment.