test: add unit test for helper on unresolved template string

garden-io · Jun 26, 2023 · 8dbff94 · 8dbff94
1 parent bdf0190
commit 8dbff94
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/src/template-string/functions.ts b/core/src/template-string/functions.ts
@@ -512,13 +512,13 @@ export function callHelperFunction({
 
       // do not apply helper function for an unresolved template string
       if (maybeTemplateString(value)) {
-        const _error = new TemplateStringError(`Function '${functionName}' cannot be applied on unresolved string`, {
-          functionName,
-          text,
-        })
         if (allowPartial) {
           return { resolved: "${" + text + "}" }
         } else {
+          const _error = new TemplateStringError(`Function '${functionName}' cannot be applied on unresolved string`, {
+            functionName,
+            text,
+          })
           return { _error }
         }
       }

diff --git a/core/test/unit/src/template-string.ts b/core/test/unit/src/template-string.ts
@@ -1053,6 +1053,13 @@ describe("resolveTemplateString", () => {
       })
     })
 
+    it("does not apply helper function on unresolved template string and returns string as-is, when allowPartial=true", () => {
+      const res = resolveTemplateString("${base64Encode('${environment.namespace}')}", new TestContext({}), {
+        allowPartial: true,
+      })
+      expect(res).to.equal("${base64Encode('${environment.namespace}')}")
+    })
+
     context("concat", () => {
       it("allows empty strings", () => {
         const res = resolveTemplateString("${concat('', '')}", new TestContext({}))