fix(k8s): env vars weren't passed to services with garden run service

garden-io · Nov 29, 2019 · 8d66f8a · 8d66f8a
1 parent d26595f
commit 8d66f8a
Show file tree

Hide file tree

Showing 4 changed files with 72 additions and 2 deletions.
diff --git a/garden-service/src/plugins/kubernetes/container/run.ts b/garden-service/src/plugins/kubernetes/container/run.ts
@@ -36,7 +36,9 @@ export async function runContainerService({
   timeout,
   log,
 }: RunServiceParams<ContainerModule>): Promise<RunResult> {
-  const { command, args } = service.spec
+  const { command, args, env } = service.spec
+
+  runtimeContext.envVars = { ...runtimeContext.envVars, ...env }
 
   return runContainerModule({
     ctx,

diff --git a/garden-service/test/data/test-projects/container/simple/garden.yml b/garden-service/test/data/test-projects/container/simple/garden.yml
@@ -2,6 +2,13 @@ kind: Module
 name: simple
 type: container
 image: busybox
+services:
+  - name: echo-service
+    command: [sh, -c, "echo ok"]
+  - name: env-service
+    command: [sh, -c, "echo $ENV_VAR"]
+    env:
+      ENV_VAR: foo
 tasks:
   - name: echo-task
     command: [sh, -c, "echo ok"]

diff --git a/garden-service/test/integ/src/plugins/kubernetes/container/container.ts b/garden-service/test/integ/src/plugins/kubernetes/container/container.ts
@@ -12,6 +12,8 @@ import { TaskTask } from "../../../../../../src/tasks/task"
 import { runAndCopy } from "../../../../../../src/plugins/kubernetes/run"
 import { Provider } from "../../../../../../src/config/provider"
 import { containerHelpers } from "../../../../../../src/plugins/container/helpers"
+import { runContainerService } from "../../../../../../src/plugins/kubernetes/container/run"
+import { prepareRuntimeContext } from "../../../../../../src/runtime-context"
 
 describe("kubernetes container module handlers", () => {
   let garden: Garden
@@ -234,6 +236,66 @@ describe("kubernetes container module handlers", () => {
     })
   })
 
+  describe("runContainerService", () => {
+    it("should run a service", async () => {
+      const service = await graph.getService("echo-service")
+
+      const runtimeContext = await prepareRuntimeContext({
+        garden,
+        graph,
+        dependencies: {
+          build: [],
+          service: [],
+          task: [],
+          test: [],
+        },
+        module: service.module,
+        serviceStatuses: {},
+        taskResults: {},
+      })
+
+      const result = await runContainerService({
+        ctx: garden.getPluginContext(provider),
+        log: garden.log,
+        service,
+        module: service.module,
+        interactive: false,
+        runtimeContext,
+      })
+
+      expect(result.log.trim()).to.eql("ok")
+    })
+
+    it("should add configured env vars to the runtime context", async () => {
+      const service = await graph.getService("env-service")
+
+      const runtimeContext = await prepareRuntimeContext({
+        garden,
+        graph,
+        dependencies: {
+          build: [],
+          service: [],
+          task: [],
+          test: [],
+        },
+        module: service.module,
+        serviceStatuses: {},
+        taskResults: {},
+      })
+
+      const result = await runContainerService({
+        ctx: garden.getPluginContext(provider),
+        log: garden.log,
+        service,
+        module: service.module,
+        interactive: false,
+        runtimeContext,
+      })
+
+      expect(result.log.trim()).to.eql("foo")
+    })
+  })
+
   describe("runContainerTask", () => {
     it("should run a basic task", async () => {
       const task = await graph.getTask("echo-task")

diff --git a/garden-service/test/unit/src/tasks/get-service-status.ts b/garden-service/test/unit/src/tasks/get-service-status.ts
@@ -7,7 +7,6 @@ import { Garden } from "../../../../src/garden"
 import { GardenPlugin } from "../../../../src/types/plugin/plugin"
 import { joi } from "../../../../src/config/common"
 import { ServiceState } from "../../../../src/types/service"
-import { DeployServiceParams } from "../../../../src/types/plugin/service/deployService"
 import { RunTaskParams } from "../../../../src/types/plugin/task/runTask"
 import { expect } from "chai"
 import { GetServiceStatusTask } from "../../../../src/tasks/get-service-status"