chore: address some lint warnings (#6548)

* chore: delete empty test files

* chore(test): suppress `@typescript-eslint/no-explicit-any` linter warnings in tests

* chore(test): address `@typescript-eslint/no-shadow` warnings in tests

* chore: address `@typescript-eslint/no-shadow` warnings

* chore: remove unnecessary `any` type in generic args

* chore: disable test-specific lint warnings

* chore: remove unnecessary `any`

* chore: replace type `{}` with `Record<string, unknown>` in action types

core/src/actions/base.ts

@@ -334,8 +334,8 @@ export interface ActionDescription {
 
 export abstract class BaseAction<
   C extends BaseActionConfig = BaseActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > {
   // TODO: figure out why kind and type come out as any types on Action type
   public readonly kind: C["kind"]
@@ -687,8 +687,8 @@ export abstract class BaseAction<
 
 export abstract class RuntimeAction<
   C extends BaseRuntimeActionConfig = BaseRuntimeActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends BaseAction<C, StaticOutputs, RuntimeOutputs> {
   /**
    * Return the Build action specified on the `build` field if defined, otherwise null
@@ -717,8 +717,8 @@ export abstract class RuntimeAction<
 // FIXME: Might be possible to remove in a later TypeScript version or through some hacks.
 export interface ResolvedActionExtension<
   C extends BaseRuntimeActionConfig = BaseRuntimeActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > {
   getDependencyResult(ref: ActionReference | Action): GraphResult | null
 
@@ -740,8 +740,8 @@ export interface ResolvedActionExtension<
 // TODO: see if we can avoid the duplication here with ResolvedBuildAction
 export abstract class ResolvedRuntimeAction<
     Config extends BaseRuntimeActionConfig = BaseRuntimeActionConfig,
-    StaticOutputs extends {} = any,
-    RuntimeOutputs extends {} = any,
+    StaticOutputs extends Record<string, unknown> = any,
+    RuntimeOutputs extends Record<string, unknown> = any,
   >
   extends RuntimeAction<Config, StaticOutputs, RuntimeOutputs>
   implements ResolvedActionExtension<Config, StaticOutputs, RuntimeOutputs>
@@ -819,8 +819,8 @@ export abstract class ResolvedRuntimeAction<
 
 export interface ExecutedActionExtension<
   _ extends BaseRuntimeActionConfig = BaseRuntimeActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > {
   getOutput<K extends keyof (StaticOutputs & RuntimeOutputs)>(
     key: K
@@ -832,8 +832,8 @@ export interface ExecutedActionExtension<
 // TODO: see if we can avoid the duplication here with ResolvedBuildAction
 export abstract class ExecutedRuntimeAction<
     C extends BaseRuntimeActionConfig = BaseRuntimeActionConfig,
-    StaticOutputs extends {} = any,
-    RuntimeOutputs extends {} = any,
+    StaticOutputs extends Record<string, unknown> = any,
+    RuntimeOutputs extends Record<string, unknown> = any,
   >
   extends ResolvedRuntimeAction<C, StaticOutputs, RuntimeOutputs>
   implements ExecutedActionExtension<C, StaticOutputs, RuntimeOutputs>

core/src/actions/build.ts

@@ -142,8 +142,8 @@ export const buildActionConfigSchema = createSchema({
 
 export class BuildAction<
   C extends BuildActionConfig<any, any> = BuildActionConfig<any, any>,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends BaseAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Build" as const
   // TODO:
@@ -194,8 +194,8 @@ export class BuildAction<
 // TODO: see if we can avoid the duplication here with ResolvedRuntimeAction
 export class ResolvedBuildAction<
     C extends BuildActionConfig<any, any> = BuildActionConfig<any, any>,
-    StaticOutputs extends {} = any,
-    RuntimeOutputs extends {} = any,
+    StaticOutputs extends Record<string, unknown> = any,
+    RuntimeOutputs extends Record<string, unknown> = any,
   >
   extends BuildAction<C, StaticOutputs, RuntimeOutputs>
   implements ResolvedActionExtension<C, StaticOutputs, RuntimeOutputs>
@@ -251,8 +251,8 @@ export class ResolvedBuildAction<
 
 export class ExecutedBuildAction<
     C extends BuildActionConfig<any, any> = BuildActionConfig<any, any>,
-    StaticOutputs extends {} = any,
-    RuntimeOutputs extends {} = any,
+    StaticOutputs extends Record<string, unknown> = any,
+    RuntimeOutputs extends Record<string, unknown> = any,
   >
   extends ResolvedBuildAction<C, StaticOutputs, RuntimeOutputs>
   implements ExecutedActionExtension<C, StaticOutputs, RuntimeOutputs>

core/src/actions/deploy.ts

@@ -32,8 +32,8 @@ export const deployActionConfigSchema = memoize(() =>
 
 export class DeployAction<
   C extends DeployActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends RuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Deploy" as const
   override _staticOutputs: StaticOutputs = {} as StaticOutputs
@@ -49,8 +49,8 @@ export class DeployAction<
 
 export class ResolvedDeployAction<
   C extends DeployActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ResolvedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Deploy" as const
 
@@ -65,8 +65,8 @@ export class ResolvedDeployAction<
 
 export class ExecutedDeployAction<
   C extends DeployActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ExecutedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Deploy" as const
 

core/src/actions/run.ts

@@ -32,8 +32,8 @@ export const runActionConfigSchema = memoize(() =>
 
 export class RunAction<
   C extends RunActionConfig = RunActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends RuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Run" as const
   override _staticOutputs: StaticOutputs = {} as StaticOutputs
@@ -49,8 +49,8 @@ export class RunAction<
 
 export class ResolvedRunAction<
   C extends RunActionConfig = RunActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ResolvedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Run" as const
 
@@ -65,8 +65,8 @@ export class ResolvedRunAction<
 
 export class ExecutedRunAction<
   C extends RunActionConfig = RunActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ExecutedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Run" as const
 

core/src/actions/test.ts

@@ -32,8 +32,8 @@ export const testActionConfigSchema = memoize(() =>
 
 export class TestAction<
   C extends TestActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends RuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Test" as const
   override _staticOutputs: StaticOutputs = {} as StaticOutputs
@@ -49,8 +49,8 @@ export class TestAction<
 
 export class ResolvedTestAction<
   C extends TestActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ResolvedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Test" as const
 
@@ -65,8 +65,8 @@ export class ResolvedTestAction<
 
 export class ExecutedTestAction<
   C extends TestActionConfig = any,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > extends ExecutedRuntimeAction<C, StaticOutputs, RuntimeOutputs> {
   override kind = "Test" as const
 

core/src/actions/types.ts

@@ -116,8 +116,8 @@ export type ActionState = (typeof actionStateTypes)[number]
 
 export interface ActionStatus<
   T extends BaseAction = BaseAction,
-  D extends {} = any,
-  O extends {} = GetActionOutputType<T>,
+  D extends Record<string, unknown> = any,
+  O extends Record<string, unknown> = GetActionOutputType<T>,
 > extends ValidResultType {
   state: ActionState
   detail: D | null
@@ -173,7 +173,7 @@ export interface ActionWrapperParams<C extends BaseActionConfig> {
   variables: DeepPrimitiveMap
 }
 
-export interface ResolveActionParams<C extends BaseActionConfig, StaticOutputs extends {} = any> {
+export interface ResolveActionParams<C extends BaseActionConfig, StaticOutputs extends Record<string, unknown> = any> {
   resolvedGraph: ResolvedConfigGraph
   dependencyResults: GraphResults
   executedDependencies: ExecutedAction[]
@@ -186,21 +186,21 @@ export interface ResolveActionParams<C extends BaseActionConfig, StaticOutputs e
 
 export type ResolvedActionWrapperParams<
   C extends BaseActionConfig,
-  StaticOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
 > = ActionWrapperParams<C> & ResolveActionParams<C, StaticOutputs>
 
 export interface ExecuteActionParams<
   C extends BaseActionConfig = BaseActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > {
   status: ActionStatus<BaseAction<C, StaticOutputs>, any, RuntimeOutputs>
 }
 
 export type ExecutedActionWrapperParams<
   C extends BaseActionConfig,
-  StaticOutputs extends {} = any,
-  RuntimeOutputs extends {} = any,
+  StaticOutputs extends Record<string, unknown> = any,
+  RuntimeOutputs extends Record<string, unknown> = any,
 > = ResolvedActionWrapperParams<C, StaticOutputs> & ExecuteActionParams<C, StaticOutputs, RuntimeOutputs>
 
 export type GetActionOutputType<T> = T extends BaseAction<any, infer O> ? O : any

core/src/cli/helpers.ts

@@ -116,7 +116,7 @@ export async function checkForUpdates(config: GlobalConfigStore, logger: Log) {
 }
 
 export interface PickCommandResult {
-  command: Command<{}, {}, any> | CommandGroup | undefined
+  command: Command<{}, {}> | CommandGroup | undefined
   rest: string[]
   matchedPath: undefined
 }

core/src/commands/self-update.ts

@@ -403,8 +403,8 @@ export class SelfUpdateCommand extends Command<SelfUpdateArgs, SelfUpdateOpts> {
             const latestVersions = await getLatestVersions(10, log)
 
             log.info(`Here are the latest available versions: ` + latestVersions.join(styles.highlight(", ")))
-          } catch (err) {
-            log.debug(`Could not retrieve the latest available versions, ${err}`)
+          } catch (e) {
+            log.debug(`Could not retrieve the latest available versions, ${e}`)
           }
 
           return {

core/src/config/zod.ts

@@ -12,6 +12,7 @@ import { envVarRegex, identifierRegex, joiIdentifierDescription, userIdentifierR
 
 // Add metadata support to schemas. See https://github.com/colinhacks/zod/issues/273#issuecomment-1434077058
 declare module "zod" {
+  // eslint-disable-next-line @typescript-eslint/no-shadow
   interface ZodType {
     getMetadata(): Record<string, any>
     setMetadata(meta: Record<string, any>): this

core/src/plugin/base.ts

@@ -151,7 +151,7 @@ export type ActionRuntimeRemotePlugin = {
 }
 
 // TODO-0.13.0: update this schema in 0.13.0
-export interface RunResult {
+export type RunResult = {
   success: boolean
   exitCode?: number
   // FIXME: we should avoid native Date objects

core/src/plugin/handlers/Build/publish.ts

@@ -22,7 +22,7 @@ interface PublishActionParams<T extends BuildAction = BuildAction> extends Plugi
   tagOverride?: string
 }
 
-export interface PublishActionDetail {
+export type PublishActionDetail = {
   published: boolean
   message?: string
   identifier?: string

core/src/plugins/container/config.ts

@@ -730,7 +730,7 @@ export interface ContainerDeploySpec extends ContainerCommonDeploySpec {
 
 export type ContainerDeployActionConfig = DeployActionConfig<"container", ContainerDeploySpec>
 
-export interface ContainerDeployOutputs {
+export type ContainerDeployOutputs = {
   deployedImageId: string
 }
 
@@ -894,7 +894,7 @@ const artifactsSchema = memoize(() =>
     .example([{ source: "/report/**/*" }])
 )
 
-export interface ContainerTestOutputs {
+export type ContainerTestOutputs = {
   log: string
 }
 
@@ -956,7 +956,7 @@ export const containerRunActionSchema = createSchema({
 
 // BUILD //
 
-export interface ContainerBuildOutputs {
+export type ContainerBuildOutputs = {
   "localImageName": string
   "localImageId": string
   "deploymentImageName": string

core/src/plugins/kubernetes/kubernetes-type/config.ts

@@ -148,7 +148,7 @@ export const kubernetesDeploySchema = () =>
     })
     .rename("devMode", "sync")
 
-export interface KubernetesRunOutputs {
+export type KubernetesRunOutputs = {
   log: string
 }
 

core/src/types/service.ts

@@ -196,7 +196,7 @@ export const forwardablePortSchema = createSchema({
   keys: forwardablePortKeys,
 })
 
-export interface ServiceStatus<D = any, O = PrimitiveMap> {
+export type ServiceStatus<D = any, O = PrimitiveMap> = {
   createdAt?: string
   detail: D
   mode?: ActionMode

core/test/.eslintrc.json

@@ -2,6 +2,6 @@
   "rules": {
     // In tests we sometimes make these chains and while they are technically wrong
     // they make the tests more readable.
-    "@typescript-eslint/no-non-null-asserted-optional-chain": "warn"
+    "@typescript-eslint/no-non-null-asserted-optional-chain": "off"
   }
 }

core/test/integ/helpers.ts

@@ -81,6 +81,7 @@ export async function getArtifactRegistryClient() {
   })
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 function isGCloudServiceError(err: any): err is GCloudServiceError {
   if (err === undefined) {
     return false
@@ -92,6 +93,7 @@ function isGCloudServiceError(err: any): err is GCloudServiceError {
 interface GCloudServiceError {
   code: number
   details: string
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   metadata: any
 }