Skip to content

Commit

Permalink
Merge pull request #66 from garden-io/validate-commits
Browse files Browse the repository at this point in the history
Validate commits + pre-push test hook
  • Loading branch information
eysi09 authored Apr 12, 2018
2 parents 91bdfa1 + f6e11d9 commit 21ecc6c
Show file tree
Hide file tree
Showing 5 changed files with 188 additions and 1 deletion.
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v9.4.0
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ discussion, pull requests, feature requests and any type of feedback. We request
adhere to the [Contributor Covenant](CODE_OF_CONDUCT.md) and work with us to make the collaboration and
community productive and fun for everyone :)

### Commit messages

We follow and automatically validate
[Angular-like formatting](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits) for our
commit messages, for consistency and clarity.

### Setting up your development environment

./bin/bootstrap-osx
Expand Down
164 changes: 164 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"@types/prettyjson": "0.0.28",
"@types/yargs": "^11.0.0",
"chai": "^4.1.2",
"husky": "^0.15.0-rc.13",
"json-schema-to-typescript": "^5.2.2",
"license-checker": "^18.0.0",
"mocha": "^4.1.0",
Expand All @@ -85,7 +86,8 @@
"tslint": "^5.8.0",
"tslint-microsoft-contrib": "^5.0.1",
"typescript": "^2.7.2",
"typescript-formatter": "^7.0.1"
"typescript-formatter": "^7.0.1",
"validate-commit": "^3.4.0"
},
"scripts": {
"add-licenses": "./bin/add-licenses",
Expand All @@ -109,5 +111,11 @@
"update-submodules": "git submodule update --init --recursive --jobs 4",
"watch": "npm run build -- -w"
},
"husky": {
"hooks": {
"commit-msg": "validate-commit-msg -p angular",
"pre-push": "npm test"
}
},
"snyk": true
}
8 changes: 8 additions & 0 deletions src/commands/environment/destroy.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
/*
* Copyright (C) 2018 Garden Technologies, Inc. <[email protected]>
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/

import { every, reduce } from "lodash"

import { Command, EnvironmentOption, ParameterValues } from "../base"
Expand Down

0 comments on commit 21ecc6c

Please sign in to comment.