-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart Home: Camera viewing and input streaming #128
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,6 +185,17 @@ set(optional_deps Alsa | |
XSLT | ||
${PLATFORM_OPTIONAL_DEPS}) | ||
|
||
# ROS dependencies. Keep in alphabetical order please | ||
list(APPEND required_deps | ||
ament_cmake | ||
image_transport | ||
oasis_msgs | ||
rcl_interfaces | ||
rclcpp | ||
rmw | ||
sensor_msgs | ||
) | ||
|
||
# Check optional deps first, since their availability can influence required ones, e.g. ffmpeg | ||
core_optional_dep(${optional_deps}) | ||
core_require_dep(${required_deps}) | ||
|
@@ -464,12 +475,6 @@ endif() | |
|
||
include(cmake/scripts/${CORE_SYSTEM_NAME}/Install.cmake) | ||
|
||
# Add uninstall target | ||
if(CMAKE_GENERATOR MATCHES Makefile) | ||
add_custom_target(uninstall COMMAND ${CMAKE_COMMAND} -P ${CMAKE_SOURCE_DIR}/cmake/scripts/common/Uninstall.cmake) | ||
set_target_properties(uninstall PROPERTIES FOLDER "Build Utilities") | ||
endif() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this removed? |
||
|
||
# Create target that allows to build binary-addons. | ||
# Use make binary-addons ADDONS="visualization.spectrum" to select the addons to build. | ||
if(CMAKE_GENERATOR STREQUAL "Unix Makefiles") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<window> | ||
<controls> | ||
<!-- Top row --> | ||
<control type="cameraview"> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/kinect2/hd/image_color</topic> | ||
</control> | ||
<control type="cameraview"> | ||
<left>33%</left> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/netbook/image_raw</topic> | ||
</control> | ||
<control type="cameraview"> | ||
<left>67%</left> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/lenovo/image_raw</topic> | ||
</control> | ||
|
||
<!-- Middle row --> | ||
<control type="cameraview"> | ||
<top>33%</top> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/kinect2/sd/image_color_rect</topic> | ||
</control> | ||
<control type="cameraview"> | ||
<top>33%</top> | ||
<left>33%</left> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/netbook/foreground</topic> | ||
</control> | ||
<control type="cameraview"> | ||
<top>33%</top> | ||
<left>67%</left> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/lenovo/foreground</topic> | ||
</control> | ||
|
||
<!-- Bottom row --> | ||
<control type="cameraview"> | ||
<top>67%</top> | ||
<width>33%</width> | ||
<height>33%</height> | ||
<topic>/oasis/kinect2/foreground</topic> | ||
</control> | ||
</controls> | ||
</window> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -332,7 +332,9 @@ macro(export_dep) | |
set(SYSTEM_INCLUDES ${SYSTEM_INCLUDES} PARENT_SCOPE) | ||
set(DEPLIBS ${DEPLIBS} PARENT_SCOPE) | ||
set(DEP_DEFINES ${DEP_DEFINES} PARENT_SCOPE) | ||
set(${dep}_FOUND ${${dep}_FOUND} PARENT_SCOPE) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do you need this? Please use ${depup} like all other depends |
||
set(${depup}_FOUND ${${depup}_FOUND} PARENT_SCOPE) | ||
mark_as_advanced(${dep}_LIBRARIES) | ||
mark_as_advanced(${depup}_LIBRARIES) | ||
endmacro() | ||
|
||
|
@@ -385,8 +387,11 @@ function(core_require_dep) | |
split_dependency_specification(${depspec} dep version) | ||
find_package_with_ver(${dep} ${version} REQUIRED) | ||
string(TOUPPER ${dep} depup) | ||
list(APPEND SYSTEM_INCLUDES ${${dep}_INCLUDE_DIRS}) | ||
list(APPEND SYSTEM_INCLUDES ${${depup}_INCLUDE_DIRS}) | ||
list(APPEND DEPLIBS ${${dep}_LIBRARIES}) | ||
list(APPEND DEPLIBS ${${depup}_LIBRARIES}) | ||
list(APPEND DEP_DEFINES ${${dep}_DEFINITIONS}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above, all those shouldn't be needed |
||
list(APPEND DEP_DEFINES ${${depup}_DEFINITIONS}) | ||
export_dep() | ||
endforeach() | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
xbmc/smarthome smarthome | ||
xbmc/smarthome/guibridge smarthome/guibridge | ||
xbmc/smarthome/guicontrols smarthome/guicontrols | ||
xbmc/smarthome/input smarthome/input | ||
xbmc/smarthome/rendering smarthome/rendering | ||
xbmc/smarthome/ros2 smarthome/ros2 | ||
xbmc/smarthome/streams smarthome/streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those must be optional, so we need an option ENABLE_SMARTHOME