feat: Stop sending cliToken in sendSubmission mutation
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 203 216 +13
Branches 20 22 +2
=========================================
+ Hits 203 216 +13
|
songz
reviewed
Jul 9, 2022
src/graphql.ts
Outdated
| @@ -28,7 +28,7 @@ export const POST_SUBMISSION = ` | |||
| mutation createSubmission( | |||
| $lessonId: Int! | |||
| $challengeId: Int! | |||
| $cliToken: String! | |||
| $cliToken: String | |||
There was a problem hiding this comment.
shouldn't we just remove this since we are not sending it?
flacial
changed the title
sendSubmission mutationcliToken in sendSubmission mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Merging this PR will stop the
sendSubmissionmutation from sending thecliToken. When most of the users upgraded their CLI, its field type will be completely removed.