Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(14): Component folder structure #2938

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

scotthallock
Copy link
Collaborator

Related to #2080

This PR folders creates folders for:

  • ProfileStarComments
  • ProfileSubmissions
  • SubmissionCard
  • UserInfoImage

With this PR, all components in the /components folder will have their own Folder with an entry point called index.tsx.

The next step will be to move story files from the /stories folder to these component folders.

@vercel
Copy link

vercel bot commented Apr 26, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 1:56am

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2938 (3557ba5) into master (80d616c) will not change coverage.
The diff coverage is n/a.

❗ Current head 3557ba5 differs from pull request most recent head 956f05a. Consider uploading reports for the commit 956f05a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2938   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines         3580      3580           
  Branches       987       987           
=========================================
  Hits          3580      3580           
Impacted Files Coverage Δ
...onents/ProfileStarComments/ProfileStarComments.tsx 100.00% <ø> (ø)
...mponents/ProfileSubmissions/ProfileSubmissions.tsx 100.00% <ø> (ø)
components/SubmissionCard/SubmissionCard.tsx 100.00% <ø> (ø)
components/UserInfoImage/UserInfoImage.tsx 100.00% <ø> (ø)

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool! We just finished one of the projects :D

@scotthallock scotthallock added this pull request to the merge queue Apr 26, 2023
Merged via the queue into garageScript:master with commit e9efb89 Apr 26, 2023
@scotthallock scotthallock changed the title WIP(13): Component folder structure WIP(14): Component folder structure Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

3 participants