Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(12): Component folder structure #2919

Merged
merged 11 commits into from
Apr 23, 2023
Merged

Conversation

scotthallock
Copy link
Collaborator

Related to #2080

This PR folders creates folders for:

  • Footer
  • Input
  • InputGroup
  • Layout
  • LoadingSpinner

@vercel
Copy link

vercel bot commented Apr 21, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 5:43pm

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2919 (d946b8b) into master (de8d796) will not change coverage.
The diff coverage is n/a.

❗ Current head d946b8b differs from pull request most recent head 1fab7a4. Consider uploading reports for the commit 1fab7a4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2919   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines         3580      3580           
  Branches       987       987           
=========================================
  Hits          3580      3580           
Impacted Files Coverage Δ
components/Footer/Footer.tsx 100.00% <ø> (ø)
components/Input/Input.tsx 100.00% <ø> (ø)
components/InputGroup/InputGroup.tsx 100.00% <ø> (ø)
components/Layout/Layout.tsx 100.00% <ø> (ø)
components/LoadingSpinner/LoadingSpinner.tsx 100.00% <ø> (ø)
components/admin/AdminLayout.tsx 100.00% <ø> (ø)

@scotthallock
Copy link
Collaborator Author

The netlify deployments are failing:

Command failed with exit code 1: yarn build-storybook (https://ntl.fyi/exit-code-1)

I wasn't having any issue with storybook locally until I re-installed all packages.

Now, when trying to run yarn storybook I get the following error:

image

Will put this PR in draft state and dig into this soon...

@scotthallock scotthallock marked this pull request as draft April 21, 2023 20:40
@flacial
Copy link
Member

flacial commented Apr 21, 2023

The netlify deployments are failing:

Command failed with exit code 1: yarn build-storybook (https://ntl.fyi/exit-code-1)

I wasn't having any issue with storybook locally until I re-installed all packages.

Now, when trying to run yarn storybook I get the following error:

image

Will put this PR in draft state and dig into this soon...

Could you check if it's related to this PR? #2907

@scotthallock
Copy link
Collaborator Author

Could you check if it's related to this PR? #2907

Yes, it must be.

Downgrading to @sentry/[email protected] and the error goes away.
Re-upgrading to @sentry/[email protected] and I get the "Can't resolve 'async_hooks' ... " error.

Release notes for @7.48.0 - many changes related to async

I'm seeing if there's a quick fix somewhere.

@scotthallock scotthallock marked this pull request as ready for review April 23, 2023 17:39
@scotthallock scotthallock added this pull request to the merge queue Apr 23, 2023
Merged via the queue into garageScript:master with commit 8c6a270 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

2 participants