Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(5): Component folder structure #2875

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

scotthallock
Copy link
Collaborator

Related to #2080

(Continuing effort from #2150)

This PR folders creates folders for CopyButton, DiscordBar, and DropdownMenu components.

@vercel
Copy link

vercel bot commented Apr 3, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2875 (b5e2d0a) into master (5def52f) will not change coverage.
The diff coverage is n/a.

❗ Current head b5e2d0a differs from pull request most recent head 28f6eb6. Consider uploading reports for the commit 28f6eb6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2875   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines         3576      3576           
  Branches       970       970           
=========================================
  Hits          3576      3576           
Impacted Files Coverage Δ
components/CopyButton/CopyButton.tsx 100.00% <ø> (ø)
components/DiscordBar/DiscordBar.tsx 100.00% <ø> (ø)
components/DropdownMenu/DropdownMenu.tsx 100.00% <ø> (ø)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to match component name

@@ -1,6 +1,6 @@
@use 'sass:color';
@use '_variables.module.scss';
@import 'colors.module.scss';
@use '../../scss/variables.module.scss';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info: you can omit the leading underscore when importing a Sass partial. (Docs)

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 3:48pm

@scotthallock scotthallock added this pull request to the merge queue Apr 3, 2023
Merged via the queue into garageScript:master with commit 2a45405 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

2 participants