Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support to exercise card and exercise preview #2390

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Add markdown support to exercise card and exercise preview #2390

merged 5 commits into from
Oct 3, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Oct 3, 2022

How to test:

  • Go to /exercises/js0
  • Check that markdown looks good

Before:
before

After:
exercise-preview-after
exercise-preview-after-mobile
exercise-card-after
exercise-card-after-mobile

@vercel
Copy link

vercel bot commented Oct 3, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
c0d3-app ✅ Ready (Inspect) Visit Preview 2 resolved Oct 3, 2022 at 3:25AM (UTC)

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #2390 (53cf671) into master (e23446a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines         3281      3281           
  Branches       871       871           
=========================================
  Hits          3281      3281           
Impacted Files Coverage Δ
components/ExerciseCard/ExerciseCard.tsx 100.00% <ø> (ø)
...onents/ExercisePreviewCard/ExercisePreviewCard.tsx 100.00% <ø> (ø)

@SlyBouhafs
Copy link
Member

I approved it but there's a small issue though, you may want to check the comments on the vercel preview.

@bryanjenningz
Copy link
Collaborator Author

I approved it but there's a small issue though, you may want to check the comments on the vercel preview.

Thanks for finding that bug! I fixed it by adding "d-block" CSS classes to the Markdown components so all markdown is display: block.

@bryanjenningz bryanjenningz merged commit 961e306 into garageScript:master Oct 3, 2022
@bryanjenningz bryanjenningz deleted the add-markdown-support-to-exercise-card-and-exercise-preview branch October 3, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants