Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate the issue of creating a submission based on the cliToken ID #1553

Merged
merged 15 commits into from
Mar 9, 2022

Conversation

flacial
Copy link
Member

@flacial flacial commented Mar 7, 2022

Closes #1551

This PR will:

  • Populate the user object based on the cliToken if it's available
  • Retrieve the user ID from the req.user object rather than the cliToken but keep the cliToken to keep it compatible with users who have older CLI versions.
  • Send an event to Sentry with the user's username and ID when cliToken exists and req.user doesn't

@vercel
Copy link

vercel bot commented Mar 7, 2022

@flacial is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel.

@garageScript first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/3KRg2KgWkZ6tmRejjUtxp6jwn363
✅ Preview: https://c0d3-app-git-fork-flacial-fixcreatesubmission-c0d3.vercel.app

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1553 (04deba5) into master (3d0be49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines         2563      2577   +14     
  Branches       660       664    +4     
=========================================
+ Hits          2563      2577   +14     
Impacted Files Coverage Δ
helpers/controllers/submissionController.ts 100.00% <100.00%> (ø)
helpers/middleware/user.ts 100.00% <100.00%> (ø)

@flacial flacial added the dont-merge Not ready for merge label Mar 7, 2022
helpers/controllers/submissionController.ts Outdated Show resolved Hide resolved
@flacial flacial merged commit be707fe into garageScript:master Mar 9, 2022
@flacial flacial deleted the fixCreateSubmission branch March 13, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security - create submission
3 participants