Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening another line comment box clears an already open one #848

Open
ggwadera opened this issue Jun 9, 2021 · 3 comments
Open

Opening another line comment box clears an already open one #848

ggwadera opened this issue Jun 9, 2021 · 3 comments
Labels
bug Something isn't working UI User Interface

Comments

@ggwadera
Copy link
Collaborator

ggwadera commented Jun 9, 2021

When you already have a line comment already open you better submit it before trying to do another one, otherwise all your effort in writing a good comment is wasted :(

Steps to reproduce:

  1. Start a new line comment in a review and type something but don't submit.
    image

  2. Keep the previous comment open and open another one in another line.
    image

  3. Go back to the first comment, you will be sad to see that it was cleared and you will have to do it all again 😥
    image

@ggwadera ggwadera added bug Something isn't working UI User Interface labels Jun 9, 2021
@ggwadera
Copy link
Collaborator Author

ggwadera commented Jun 9, 2021

@Ulisseus

@songz
Copy link
Contributor

songz commented Jun 9, 2021

haha ouch!

@Ulisseus
Copy link
Collaborator

Ulisseus commented Jun 9, 2021

Yes, I never thought that someone would write a comment and instead of submitting it start writing the new one. Creating new commentbox triggers rerender so everything which isn't written to db disappears.

I'm trying to add normal comments under submission right now. Once I finish it I'll come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI User Interface
Projects
None yet
Development

No branches or pull requests

3 participants