Fix bug with iterating over non-reduced stab chains #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-konovalov This patch also needs to be in stable-4.8 (sorry should have probably put it there in the first place). Not sure the cleanest way to do that. |
|
@ChrisJefferson OK - I've assigned it to GAP 4.8.5 and will cherry-pick on stable-4.8 as soon as GAP 4.8.4 will be out. Have to remember that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Iteratorfor permutation groups was broken when theStabChainMutableof the group was not reduced (which can reasonably happen as the result of various algorithms). I decided the easiest way to fix the algorithm was to just throw away any trivial elements from the end of the stab chain, as they are the ones causing trouble (ones in the middle / start may slightly increase work, but don't cause a bug).@markuspf might want to take a glance at this, as this is his code I'm tweaking.