Merge pull request #61 from fingolfin/mh/no-EvalString

Avoid unnecessary uses of EvalString
gap-packages · Jan 11, 2024 · e90b89c · e90b89c
2 parents c5ed6d3 + 7f46bd8
commit e90b89c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/gap/helpers.gi b/gap/helpers.gi
@@ -484,8 +484,8 @@ InstallGlobalFunction(WordGrowth, function(arg)
         if IsString(draw) then
             AppendTo(draw,S);
         else
-            if IsBound(JupyterRenderable) then
-                return EvalString("JupyterRenderable")(rec(("image/svg+xml") :=IO_PipeThrough("dot",["-Tsvg"],S)),rec());
+            if IsBoundGlobal("JupyterRenderable") then
+                return ValueGlobal("JupyterRenderable")(rec(("image/svg+xml") :=IO_PipeThrough("dot",["-Tsvg"],S)),rec());
             else
                 DOT2DISPLAY@(S, "neato");
             fi;
@@ -498,7 +498,7 @@ end);
 InstallOtherMethod(Draw, "(FR) default",
         [IsObject],
         function(l)
-    if IsBound(JupyterRenderable) then
+    if IsBoundGlobal("JupyterRenderable") then
         return WordGrowth(l,rec(draw:=true));
     else
         WordGrowth(l,rec(draw:=true));
@@ -516,7 +516,7 @@ InstallOtherMethod(Draw, "(FR) default, with options",
         function(l,options)
     options := ShallowCopy(options);
     options.draw := true;
-    if IsBound(JupyterRenderable) then # a hack
+    if IsBoundGlobal("JupyterRenderable") then # a hack
         return WordGrowth(l,options);
     else
         WordGrowth(l,options);

diff --git a/gap/mealy.gi b/gap/mealy.gi
@@ -1195,8 +1195,8 @@ end);
 
 BindGlobal("DRAWMEALY@", function(M)
      # more a hack than a clean implementation...
-    if IsBound(JupyterRenderable) then
-        return EvalString("JupyterRenderable")(rec(("image/svg+xml") :=IO_PipeThrough("dot",["-Tsvg"],MM2DOT@(M))),rec());
+    if IsBoundGlobal("JupyterRenderable") then
+        return ValueGlobal("JupyterRenderable")(rec(("image/svg+xml") :=IO_PipeThrough("dot",["-Tsvg"],MM2DOT@(M))),rec());
     else
         DOT2DISPLAY@(MM2DOT@(M),"dot");
     fi;