Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins to newer versions #330

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jochen314
Copy link
Contributor

This PR retrieves the version of the currently installed plugin and compares it to the new version.
If they differe, the the plugin will be updated.

Also: Use the complete build# when checking for plugins.
There are some plugins, which are only available for the ultimate edition (org.jetbrains.plugins.vue)

BTW: is get_build_info_from_jar still needed? I could not find a version which uses this. And I don't know, how to figure out the product code in this case

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

also use the complete build# when checking for plugins - it makes a difference
@freemanjp
Copy link
Member

@jochen314 I appreciate the effort you put into this PR. However, supporting plugin updates is a bit of an issue for a few reasons:

  • Once IntelliJ added support for Project Required Plugins, it made installing plugins via Ansible largely redundant (frankly, I'm reluctant to invest much more effort in maintaining this feature if it has limited value).
  • Ansible is good at installing software but poor at updating it. It lacks the features of package managers like Apt/Yum for tracking installed files and using it to uninstall previous versions during upgrades. Ansible is a better fit for an immutable infrastructure approach (i.e. rebuild rather than update).
  • Given IntelliJ can update outdated plugins, I'm not sure how much value this would add.
  • To add support for updating plugins, the rest of the role would also need to support updates.
  • The roles Molecule tests would need enhancing to test updates.

Adding support for Ultimate plugins is a good idea.

As for get_build_info_from_jar, it's needed for IntelliJ versions prior to 2021.2 (see #291), I don't think it's old enough to remove yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants