-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile #38
Conversation
fix warning during docker build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rheyser can you please log into the branch and run pre-commit to let it update the versions.
then ping me.
other wise this looks good.
@gamethis It’s run. It seems to force updates to the pinned versions in that workflow and having old versions there was good to test candidates knowledge of terraform. We may want to have an exercise that allows for that case. And sorry about the billion commits, I did this on my phone in the visual editor. |
fix warning during docker build
SUMMARY
Currently, a person doing the exercises will see a warning during the docker build step. Capitalizing
AS
to matchFROM
fixes that.PR TYPE
ADDITIONAL INFORMATION
Just do the steps in exercise2, you'll see the warning during the image build step.