Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #38

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Update Dockerfile #38

merged 13 commits into from
Oct 14, 2024

Conversation

rheyser
Copy link
Contributor

@rheyser rheyser commented Sep 26, 2024

fix warning during docker build

SUMMARY

Currently, a person doing the exercises will see a warning during the docker build step. Capitalizing AS to match FROM fixes that.

PR TYPE

  • EXERCISE

ADDITIONAL INFORMATION

Just do the steps in exercise2, you'll see the warning during the image build step.

FromAsCasing: 'as' and 'FROM' keywords' casing do not match

fix warning during docker build
Copy link
Owner

@gamethis gamethis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rheyser can you please log into the branch and run pre-commit to let it update the versions.
then ping me.
other wise this looks good.

@rheyser
Copy link
Contributor Author

rheyser commented Oct 10, 2024

@gamethis It’s run. It seems to force updates to the pinned versions in that workflow and having old versions there was good to test candidates knowledge of terraform. We may want to have an exercise that allows for that case.

And sorry about the billion commits, I did this on my phone in the visual editor.

@gamethis gamethis merged commit c8b2719 into gamethis:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants