Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scraper of unity versions #43

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: scraper of unity versions #43

merged 1 commit into from
Dec 12, 2022

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Dec 10, 2022

Changes

How to test:

Go to Unity Editor archive page and run this in your console:

document.querySelectorAll('.release-links div:first-child a[href]').forEach(link => console.log(link.href))

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@AndrewKahr
Copy link
Member

Wondering if now would actually be a good time to switch to scraping via their artifact server rather than trying to scrape their front end which changes style.

The link for reference: https://symbolserver.unity3d.com/000Admin/history.txt

@webbertakken
Copy link
Member Author

webbertakken commented Dec 10, 2022

Wondering if now would actually be a good time to switch to scraping via their artifact server rather than trying to scrape their front end which changes style.

The link for reference: https://symbolserver.unity3d.com/000Admin/history.txt

Great suggestion.
For now I'm pretty happy with the "proven to work" way as this is a relatively easy fix.

Note that one of the releases has missing mono.pdb from previous releases inside the version field.

Copy link
Member

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images missing for Unity 2022.2.0f1 and 2022.1.24f1
4 participants