Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for macos #211

Open
Kariaro opened this issue Dec 27, 2022 · 4 comments
Open

Add support for macos #211

Kariaro opened this issue Dec 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Kariaro
Copy link

Kariaro commented Dec 27, 2022 •
edited
Loading

Context
I need to test that external libraries work in Windows, Linux and Macos.

Currently macos is not supported. That's why I'm making this issue

Suggested solution

Copy code from game-ci/unity-builder that handles darwin systems and use it in this repository

Additional details

I'm going to try make a PR for this issue myself and will clone this repository to start testing
@webbertakken
Copy link
Member

Yup! We support this approach and accept contributions.

@Kariaro
Copy link
Author

Kariaro commented Dec 27, 2022

I'm currently looking at the generated docker images for macos but I don't see any here: https://github.com/game-ci/docker/tree/main/images/macos

Should I copy the MacBuilder concept from https://github.com/game-ci/unity-builder/blob/main/src/model/mac-builder.ts and apply it so that if process.platform === 'darwin' I jump to the MacTestRunner instead?

@davidmfinol
Copy link
Member

That's right, there are no docker images for macos, so you would likely need to copy the relevant typescript code from unity-builder.

Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
d4a30c2
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
97a959b
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
3e05aa6
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
51379a3
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
dab01d4
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
5d79d83
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
bb45a1b
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
b477563
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
87ab0af
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
26277c4
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
fd3d5de
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
dd60589
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
084c4f3
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
d57b5a0
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
0772645
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
734a01b
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
f2b2493
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
@Kariaro
feat: Add support for macos game-ci#211
4c346c0
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
@Kariaro
feat: Add support for macos game-ci#211
7aa4ba1
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
@Kariaro
feat: Add support for macos game-ci#211
4eff5ec
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
@Kariaro
feat: Add support for macos game-ci#211
001626a
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
@Kariaro
feat: Add support for macos game-ci#211
f2baac2
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
@Kariaro
feat: Add support for macos game-ci#211
74921d3
@Kariaro Kariaro mentioned this issue Dec 28, 2022
Closed
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
6d10be0
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
576d59c
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
9500848
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
3e29bfe
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
85cd025
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
d2928b1
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
09bb5b9
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
db5492e
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
e731b63
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
9525e59
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
fd67b21
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
9997a79
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@Kariaro
feat: Add support for macos game-ci#211
520cfb6
@davidmfinol davidmfinol added the enhancement New feature or request label Feb 9, 2023
@MichaelGlaive
Copy link

Any news here?
Any help needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidmfinol @webbertakken @Kariaro @MichaelGlaive