Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump image version from 1 to 2 in Ubuntu and Windows #59

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix: Bump image version from 1 to 2 in Ubuntu and Windows #59

merged 2 commits into from
Sep 22, 2023

Conversation

EricRibeiro
Copy link
Member

@EricRibeiro EricRibeiro commented Sep 19, 2023 •
edited
Loading

Changes

  • Bump image version in the ubuntu and ubuntu-container-runner executors
  • Bump image version in the Windows prepare-env script.
  • Comment out Windows tests due to activations error.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Documentation (updated or not needed)
  • Tests (added, updated or not needed)

@EricRibeiro EricRibeiro linked an issue Sep 19, 2023 that may be closed by this pull request
Newer versions of Unity do not properly build using gameci and unity-orb #58
Closed
brivu
brivu approved these changes Sep 19, 2023
View reviewed changes
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@KyleTryon KyleTryon self-requested a review September 22, 2023 17:31
@EricRibeiro EricRibeiro merged commit f4aef31 into main Sep 22, 2023
2 checks passed
@EricRibeiro EricRibeiro deleted the fix/image-vesion branch September 22, 2023 19:22
@peyman1959 peyman1959 mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brivu brivu brivu approved these changes

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer versions of Unity do not properly build using gameci and unity-orb
3 participants
@EricRibeiro @KyleTryon @brivu