Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom arguments and executeMethod #36

Merged
merged 11 commits into from
Sep 22, 2022
Merged

feat: allow custom arguments and executeMethod #36

merged 11 commits into from
Sep 22, 2022

Conversation

EricRibeiro
Copy link
Member

Motivation

Closes #34

Changes

  • Add support for custom execution methods and arguments in macOS and Windows
  • Add tests with custom arguments
  • Add tests with a custom execution method

Notes

Before adding support for Linux we will have to stop downloading and executing GitLab's script. This will require a small decoupling effort that I'll get to in another PR.

Copy link

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 😄

@EricRibeiro EricRibeiro merged commit b737a31 into game-ci:main Sep 22, 2022
@EricRibeiro EricRibeiro deleted the feat_custom_exec_method branch September 22, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom execution method and custom arguments
2 participants