Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no_output_timeout to commands and jobs #32

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

EricRibeiro
Copy link
Member

Changes

  • Add a new no_output_timeout parameter to the build and test jobs.
  • Add the same parameters to the prepare-env, build and test commands.

Motivation

Closes #30

Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KyleTryon
Copy link
Member

Looks like this solves #30.

As a general comment, I wonder if in the future we may want to raise the default value from 10m if this will be common for the use-case

@EricRibeiro
Copy link
Member Author

Looks like this solves #30.

As a general comment, I wonder if in the future we may want to raise the default value from 10m if this will be common for the use-case

I would argue that we should do it now. I'll raise it to 20 minutes and we can revisit the value if folks still have this issue.

@EricRibeiro EricRibeiro merged commit dd8b2f3 into main Sep 19, 2022
@EricRibeiro EricRibeiro deleted the feat_no_output_timeout_param branch September 19, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Unity Project Times Out
3 participants