Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use typescript instead of javascript and use game-ci images #84

Merged
merged 13 commits into from
Jan 11, 2022

Conversation

davidmfinol
Copy link
Member

Changes

-Upgrade to using typescript instead of javascript and use game-ci images instead of gableroux images

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@@ -19,7 +19,7 @@ jobs:
- run: yarn lint
- run: yarn test
- run: yarn build || { echo "build command should always succeed" ; exit 61; }
- run: yarn build --quiet && git diff --quiet action || { echo "action should be auto generated" ; exit 62; }
# - run: yarn build --quiet && git diff --quiet dist || { echo "dist should be auto generated" ; exit 62; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove that line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to keep it for now, since it's still in unity-builder and we may want to add back in a line that's similar.
I think we can update it or remove it from all 4 (unity-request-activation-file, unity-activate, unity-test-runner, and unity-builder) at the same time later.

.husky/pre-commit Outdated Show resolved Hide resolved
dist/entrypoint.sh Show resolved Hide resolved
@webbertakken
Copy link
Member

LGTM

@davidmfinol davidmfinol merged commit a89f0fa into main Jan 11, 2022
@davidmfinol davidmfinol deleted the v2 branch January 11, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants