Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zip and unzip to the base image #197

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Jan 27, 2023

Changes

  • Add zip and unzip to the base image (1205 kB) as some Unity packages leverage it for working with Android libraries.

One example is Microsoft App Center for Unity as it uses it to unzip aar's for Android builds to modify settings within the aar before rezipping it for the build process. The editor install docker image also utilizes unzip for certain Android setup steps.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some references to docs or example libraries would be useful to have in the rationale.

Other than that LGTM.

@AndrewKahr AndrewKahr merged commit 948e7a3 into game-ci:main Apr 5, 2023
mob-sakai pushed a commit to mob-sakai/docker that referenced this pull request Apr 10, 2023
* Add zip and unzip to the base image

* Don't attempt to install unzip for 2018 android as it has moved to base

* Force hub version to specific version on windows
mob-sakai pushed a commit to mob-sakai/docker that referenced this pull request Dec 27, 2023
* Add zip and unzip to the base image

* Don't attempt to install unzip for 2018 android as it has moved to base

* Force hub version to specific version on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants