Add 'headers' parameter to http-get for specifying request headers #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a keyword parameter called
headers
tohttp-get
so that an alist of request headers can be specified for the request. I've also converted the two existing optional parameters to keyword parameters to make it a little easier to call.Since I'm not as familiar with the coding patterns of Gambit core libraries, could you help me figure out the right way to replace the
macro-check-*
calls that I removed fromhttp-get
? I'm not sure how that pattern changes when switching to keyword arguments./cc @FredericHamel