Resolve <sys/sysctl.h> header deprecation notices on Linux #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't perfect since it doesn't take into account _when_ this deprecation should be handled, though narrowing down this down to a select platform seems to be an excellent first step. As an aside, this change probably circumvents the intention of the deprecation notice. Maybe this wasn't a good idea to handle just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't perfect since it doesn't take into account when this
deprecation should be handled, though narrowing down this warning
to a select platform seems to be an excellent first step.
As an aside, this change probably circumvents the intention of the
deprecation notice. Maybe this wasn't a good idea to handle just
yet.
Edit: Fix grammatical issue