staticanalysis #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is not yet complete. There is a balance between following
the warnings provided by shellcheck and simply disabling some, since we
don't want to wipe out too much of git blame's history (such as not
quoting filesystem paths, since unquoted paths are all over the codebase
by now).
Right now, only egs/wsj/s5/{utils,steps} are checked. I don't know
whether it's worth it to check local/ directories.
Right now, to find static analysis warnings, I am running
tools/extras/travis_script.sh from the top-level directory.
Note that some warnings are already disabled. Shellcheck warning codes
are described in more detail at: https://github.com/koalaman/shellcheck/wiki
We will need to uncomment some code in tools/extras/travis_script.sh
before pushing this.
I have not yet tested that .travis.yml is correct yet, since I don't
know travis CI very well.
This reverts commit c177939.
galv
force-pushed
the
static-analysis
branch
from
656ba01 to
8d1e4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Galvez,
I commit a PR to your staticanalysis, you can check it ,thanks
@galv