Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go generate #823

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Fix go generate #823

merged 6 commits into from
Feb 22, 2023

Conversation

tbezman
Copy link
Collaborator

@tbezman tbezman commented Feb 21, 2023

genqlclient and gqlgen aren't playing nice together. Since we added federation support, gqlgen automatically injects some schema stuff for us that genqlclient doesn't know about.

I've fixed this by vendoring the federation schema and telling genqlclient about it explicitly.

I also fixed the issue with the missing go dep by adding go get xxx to go:generate as recommended by this thread 99designs/gqlgen#1483 (comment)

@tbezman tbezman marked this pull request as ready for review February 21, 2023 20:55
Copy link
Collaborator

@jarrel-b jarrel-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Copy link
Collaborator

@Robinnnnn Robinnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're a wizard, harry

@tbezman tbezman merged commit c6451d7 into main Feb 22, 2023
@tbezman tbezman deleted the fix-gql-generation branch February 22, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants