FIX Improve masks returned by get_roi_masks and correctly split into left/right hemispheres
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdoc
changed the title
|
Pinging @marklescroart to double check if there are some edge cases I haven't thought about that would fail miserably here. |
|
b5f0f76 fixes an additional bug with Before:
After:
|
mvdoc
changed the title
get_roi_masks and correctly split into left/right hemispheres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an ROI mask or a set of vertices within an ROI, the code previously returned only vertices on the flatmap. This is fine in general, but if the ROI spans a cut, then those vertices won't be included and the ROI mask will ignore some voxels.
This PR fixes this issue by including the neighboring vertices that are not present in the flatmap.
Example: before/after for
get_roi_verts.Before
After
Example: before/after for
get_roi_masks.Before
After
