enable loading of pycortex datasets that have old subject names #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marklescroart could you rebase on the current main branch and push, to make sure that the tests pass? |
…ets with old subject names can be loaded with new subject name
TomDLT
force-pushed
the
dataset_load_old_subject
branch
from
aeb9d36 to
9f0c828
Compare
TomDLT
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added keyword to Dataset.from_file and propagated so saved datasets with old subject names can be loaded with new subject name. This has happened fairly often esp with early saving of e.g. localizer data for WIP subjects (saved as a dataset for MLwip or whatever, then can't load saved data once 'wip' is removed from subject name).
Should be a harmless add.