Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX update nibabel deprecated methods #457

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

TomDLT
Copy link
Contributor

@TomDLT TomDLT commented Jul 11, 2022

Fix failing test with recent nibabel (as in #456 for example).

See nibabel 2.1 changelog:

Deprecation of get_header, get_affine method of image objects for removal in version 4.0;

Copy link
Contributor

@mvdoc mvdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our website is currently down, so our docs fail trying to access the retinotopy data of the example subject. I'll go ahead and merge. Thanks!

@mvdoc mvdoc merged commit 876a554 into gallantlab:main Jul 11, 2022
mvdoc added a commit to mvdoc/pycortex that referenced this pull request Jul 12, 2022
…bglview

* 'fix/webglview' of github.com:mvdoc/pycortex:
  Increase wait time
  MNT remove unused code
  FIX avoid querying too many times
  Missed one line
  ENH try to add waiting time directly to JSProxy
  FIX reuse the surface obj
  FIX deal with keyerror in how __getattr__ is defined
  FIX generalize how to get an attr from self.ui
  Better print message
  Attempt to fix JS UI errors
  FIX update nibabel deprecated methods (gallantlab#457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants