FIX copy filestore in wheel #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great, thanks! Do you think it would be worth adding an extra step in the github actions to test the install from wheel vs. from sdist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447 Probably fixes #448
Related to #433
Before: The sdist archive (
.tar.gz) available on Github or PyPI correctly contains the filestore. However, whenpipcompiles the archive, it creates a wheel (.whl) without the filestore, and caches it for future re-install. Installing from the wheel would then fail to initialize the filestore (subject database and colormaps).After: The wheel now contains the filestore, which is copied in the right location during the install.
Tested on my machine, installing either from
.tar.gz, from cached.whl, or from manually created.whl..../tomdlt/miniconda3/envs/py37/share/pycortexpip install --user, filestore copied to:.../tomdlt/.local/share/pycortexI also removed the
MANIFESTfile, which seems unused or redundant withMANIFEST.in.(Also not sure why fae450e is a different commit than 5a9d07f.)