MNT change default fsl-prefix and 2D colormap #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fsl_prefix` is needed to be specified only if FSL is installed with NeuroDebian (and users do not want to source it with `/etc/fsl/fsl.sh` every time). However, FSL is stuck to 5.0 in NeuroDebian, and most people would install FSL with other means (e.g. the python FSL installer). So I think we should set the prefix to blank by default (see #443). This PR also changes the default 2D colormap from RdBu_covar to PU_BuOr_covar, which I believe is a better default.
TomDLT
approved these changes
May 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsl_prefixis needed to be specified only if FSL is installed with NeuroDebian (and users do not want to source it with/etc/fsl/fsl.shevery time). However, FSL is stuck to 5.0 in NeuroDebian, and most people would install FSL with other means (e.g. the python FSL installer). So I think we should set the prefix to blank by default (see #443).This PR also changes the default 2D colormap from RdBu_covar to PU_BuOr_covar, which I believe is a better default.