FIX ignore masked voxels when averaging with nanmean=True #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When averaging over voxels to produce a flatmap, NaNs can be ignored using
nanmean=True
.However, if the data is masked (e.g. with a "thin" mask), masked voxels are not ignored like NaNs.
Example with data filled with 1s and NaNs:
"thick" mask: correct behavior, averaging 1s into 1s, and NaNs into NaNs.
"thin" mask: incorrect behavior, averaging 1s into value in [0, 1].
The fix is to use
masked_data.filled()
, which fills masked numpy arrays with the value infill_vallue
.