Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed name of cortex.align.fs_manual to cortex.align.manual #434

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

marklescroart
Copy link
Contributor

with deprecation warnings and legacy function fs_manual() that now just maps to manual()

…eprecation warnigns and legacy function fs_manual() that now just maps to manual()
@mvdoc
Copy link
Contributor

mvdoc commented Mar 31, 2022

thanks! I'm wondering if we should explicitly throw a DeprecationWarning. This will also make it easier to figure out what needs to be removed in the next release (by grepping DeprecationWarning). What do you think @TomDLT ?

cortex/align.py Outdated Show resolved Hide resolved
cortex/align.py Outdated Show resolved Hide resolved
@mvdoc mvdoc merged commit bb2a4fc into main Apr 1, 2022
@mvdoc mvdoc deleted the manual_align_rename branch June 9, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants