Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Enhancements to cortex.export #394

Merged
merged 11 commits into from
Jun 29, 2021
Merged

ENH Enhancements to cortex.export #394

merged 11 commits into from
Jun 29, 2021

Conversation

mvdoc
Copy link
Contributor

@mvdoc mvdoc commented Jun 24, 2021 •
edited
Loading

Changes

  • Add a new view for plot_panels with dorsal view and inflated brains
  • Add keyword arguments to save_3d_views and plot_panels to select the type of interpolation (nearest or trilinear) and the number of layers
  • Apply black cortex.export
  • Move panel parameters to its own private submodule

Example new view:
image

Example new view with trilinear and 32 layers:
image

@mvdoc mvdoc changed the title ENH,REF add new view with dorsal inflated surface ENH Enhancements to cortex.export Jun 26, 2021
TomDLT
TomDLT approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@mvdoc mvdoc merged commit 91c9aa7 into main Jun 29, 2021
@mvdoc mvdoc deleted the enh/views branch December 6, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdoc @TomDLT