New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set config.filebrowserUploadMethod to "form" #847

Merged

galetahub merged 1 commit into galetahub:master from jarongao:set_filebrowserUploadMethod_to_form

May 15, 2019

Contributor

jarongao commented May 12, 2019 •

edited

Loading

CKEditor 4.9 introduced "xhr" file uploads and also made it default
config.filebrowserUploadMethod needs to be explicitly set as "form"
for URL query params to function the same as pre-4.9 CKEditor
Docs for this param:

Default config fix for #829


          Set config.filebrowserUploadMethod to "form"

ee60560

- CKEditor 4.9 introduced "xhr" file uploads and also made it default
- config.filebrowserUploadMethod needs to be explicitly set as "form"
  for URL query params to function the same as pre-4.9 CKEditor
- Docs for this param:
  - https://github.com/galetahub/ckeditor/blob/74c188c5bb7197c67197272f55951ca1c0864cda/vendor/assets/javascripts/ckeditor/CHANGES.md#ckeditor-49
  - ckeditor/ckeditor4#1365
  - ckeditor/ckeditor4@4e0866c

galetahub merged commit f670d23 into galetahub:master

jarongao deleted the set_filebrowserUploadMethod_to_form branch

May 15, 2019 17:44

javierm mentioned this pull request

Fix uploading images through CKEditor's upload tab consuldemocracy/consuldemocracy#3901

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet