Make sure the Travis build fails when website cannot be built #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
travis-must-fail
branch
from
d396e7b to
f6c972b
Compare
|
Please see this diff: https://github.com/galaxyproject/training-material/compare/verify-travis-must-fail. First commit should have failed (change in a YAML file that makes it invalid) but it does not. That's the current Second commit is the one proposed here, which now fails the build. Third commit reverts the first one, should be back to green. |
willdurand
changed the title
bebatut
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR prevents the website to be broken by ensuring that an error at build time is caught by Travis. I have also added a check to the
publishscript to avoid publishing an empty website. Both changes should avoid yesterday's situation.Note: the
|| return 0should be removed as soon as all htmlproofer errors are fixed.