Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernization of Galaxy101 #4844

Merged
merged 13 commits into from
Mar 21, 2024
Merged

modernization of Galaxy101 #4844

merged 13 commits into from
Mar 21, 2024

Conversation

nekrut
Copy link
Collaborator

@nekrut nekrut commented Mar 18, 2024

Updated all to latest interface features and updated tool versions

@nekrut nekrut requested a review from a team as a code owner March 18, 2024 16:26
bgruening
bgruening reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • topics/introduction/images/open_wf_editor.png is not needed anymore?
  • topics/introduction/images/history_options_menu.png --> why the black background?
  • the gif is great but somehow a bit blurry topics/introduction/images/drag_n_drop_dataset.gif

@nekrut
Copy link
Collaborator Author

nekrut commented Mar 18, 2024

  • topics/introduction/images/open_wf_editor.png is not needed anymore?
    It is needed
  • topics/introduction/images/history_options_menu.png --> why the black background?
    To emphasize the edge of the window
  • the gif is great but somehow a bit blurry topics/introduction/images/drag_n_drop_dataset.gif
    Let's keep it as is

hexylena
hexylena requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of really good improvements @nekrut! I've made a few small requests, if you can handle those we can merge it :) I wish all reviews were this easy!

faqs/galaxy/datasets_change_dbkey.md Outdated Show resolved Hide resolved
faqs/galaxy/histories_list.md Outdated Show resolved Hide resolved
shared/images/datasets_dbkey.svg Outdated Show resolved Hide resolved
shared/images/histories_side_by_side_view.svg Outdated Show resolved Hide resolved
shared/images/history_create_new.svg Outdated Show resolved Hide resolved
topics/introduction/tutorials/galaxy-intro-101/tutorial.md Show resolved Hide resolved
topics/introduction/tutorials/galaxy-intro-101/tutorial.md Outdated Show resolved Hide resolved
topics/introduction/tutorials/galaxy-intro-101/tutorial.md Show resolved Hide resolved
@hexylena
Copy link
Member

hexylena commented Mar 19, 2024 •
edited
Loading

@bgruening please feel free to make those comments directly on the relevant files in the future! it'll be easier for other reviewers and the author :)

hexylena
hexylena reviewed Mar 21, 2024
View reviewed changes
topics/introduction/images/history_options_menu.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is a nicer background colour, good choice.

hexylena
hexylena previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a big improvement, it was far too out of date. And everything fits well with the GTN style. Thank you @nekrut!

@hexylena hexylena merged commit 858a4fa into galaxyproject:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

@hexylena hexylena hexylena approved these changes

Assignees

@bgruening bgruening

Labels
faqs introduction template-and-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nekrut @hexylena @bgruening