Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use material ID instead of title + topic title for aggregating feedback #4739

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

hexylena
Copy link
Member

@hexylena hexylena commented Feb 19, 2024

this should be slightly more rewrite safe and we'll need to keep it up a little bit less...

i've converted the ones in the google sheet, we just need to move the replacement column two times left, and it'll be ready (should be done when this is merged to prevent issues.)

the other bonus of course is that the remapping in the future to a new material can be done automatically by looking through redirect_from and discovering previous IDs for a material (this is not currently implemented) whereas we don't have historical titles without walking the git history. So we'll never have to update this file again (hopefully.)

Also adds a new yaml formatted output (feedback2.yaml) that's a bit easier to walk through for a specific tutorial

---
introduction:
  galaxy-intro-101:
  - rating: 5
    pro: very detailed and easy to follow, even for a complete beginner - great!
    con:
    date: '2018-09-14'
    lang:
  - rating: 5
    pro:
    con:
    date: '2018-09-24'
    lang:
  - rating: 5
    pro:
    con:
    date: '2018-09-25'
    lang:

image

bin/prepare_feedback.rb Outdated Show resolved Hide resolved
github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

@shiltemann shiltemann merged commit 7c93301 into main Feb 20, 2024
3 checks passed
@hexylena hexylena deleted the pirate-bitterling branch February 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants