Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken link to Docker image missing Topic parameter in URL #4588

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Dec 13, 2023

Greenshot 2023-12-13 18 01 08

@hujambo-dunia
Copy link
Contributor Author

Hi @hexylena it appears that the Topic Name got detached from an actual value and was outputting a blank string which created a 404-error when users tried to click the "Available on these Galaxies" >> "Docker image" link. Please check on your local that my suggested fix works. Open to edits.

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @hujambo-dunia for noticing this!

We'll probably deprecate the docker containers long term since the lack of updates to the base container mean they're not going to provide as nice of an experience as using one of the public servers, but for now great to have this corrected!!

(I've made an additional commit to use one of the already-included variables, since accesses to site.data incur a small performance hit on building, but that's a very esoteric bit of jekyll performance trivia.)

@hexylena hexylena marked this pull request as ready for review December 14, 2023 08:29
@hexylena hexylena merged commit 362458b into galaxyproject:main Dec 14, 2023
3 checks passed
@hujambo-dunia
Copy link
Contributor Author

Thanks so much @hujambo-dunia for noticing this!

We'll probably deprecate the docker containers long term since the lack of updates to the base container mean they're not going to provide as nice of an experience as using one of the public servers, but for now great to have this corrected!!

(I've made an additional commit to use one of the already-included variables, since accesses to site.data incur a small performance hit on building, but that's a very esoteric bit of jekyll performance trivia.)

@hexylena Thanks for your correction - appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants